Always notify Account when FirestoreAccountStorage receives snapshot #49
Conversation
There was a problem hiding this comment.
Thank you for the quick fix @Supereg!
Would be amazing if we can add the small regression test that you noted on Slack; otherwise happy to see it merged 👍
Also looks like one of the tests is currently failing; would be good to investigate this as well: https://github.com/StanfordSpezi/SpeziFirebase/actions/runs/12225668289/job/34099948868?pr=49#step:16:2299
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #49 +/- ##
==========================================
+ Coverage 68.65% 68.72% +0.08%
==========================================
Files 19 19
Lines 1199 1202 +3
==========================================
+ Hits 823 826 +3
Misses 376 376
Continue to review full report in Codecov by Sentry.
|
Always notify Account when FirestoreAccountStorage receives snapshot
♻️ Current situation & Problem
With StanfordSpezi/SpeziAccount#79 we only forward "complete" account details to the
setupCompleteclosure of theAccountSetupview. This requires that the StorageProvider always updates the account details (to clear the incomplete flag) even if there aren't any keys stored in the storage provider. This wasn't the case for FirestoreAccountStorage resulting in thesetupCompleteclosure to never be called and theincompleteflag to never be cleared.⚙️ Release Notes
incompleteflag would never be cleared if there weren't any details stored for an account.📚 Documentation
--
✅ Testing
--
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: